Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage
Date	2017-07-04 09:30 +0200
Message-ID	<tZqrv-5a4-11@gated-at.bofh.it> (permalink)
References	<tZhex-7h6-5@gated-at.bofh.it> <tZhex-7h6-9@gated-at.bofh.it> <tZhod-7kC-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 03, 2017 at 11:44:30PM +0200, Rafael J. Wysocki wrote:
> On Mon, Jul 3, 2017 at 11:33 PM, Loc Ho <lho@apm.com> wrote:
> > The current SPCR code does not check the access width of the mmio, and
> > uses a default of 8bit register accesses.  This prevents devices that
> > only do 16 or 32bit register accesses from working.  By simply checking
> > this field and setting the mmio string appropriately, this issue can be
> > corrected.  To prevent any legacy issues, the code will default to 8bit
> > accesses if the value is anything but 16 or 32.
> >
> > Signed-off-by: Loc Ho <lho@apm.com>
> > [Re-send as single patch set]
> > Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> 
> Greg, Aleksey, any objections here?
> 
> If not, I'll route this through the ACPI tree.

No objections from me for either of these patches:
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage Loc Ho <lho@apm.com> - 2017-07-03 23:40 +0200
  Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage "Rafael J. Wysocki" <rafael@kernel.org> - 2017-07-03 23:50 +0200
    Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio  usage Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-04 09:30 +0200

csiph-web