Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	"David.Wu" <david.wu@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328
Date	Tue, 04 Jul 2017 09:40:02 +0200
Message-ID	<tZqBc-5fa-7@gated-at.bofh.it> (permalink)
References	<tXGK6-7yG-5@gated-at.bofh.it> <tXGK7-7yG-39@gated-at.bofh.it> <tZeA2-5go-13@gated-at.bofh.it>
X-Original-To	Boris Brezillon <boris.brezillon@free-electrons.com>
X-263anti-Spam	KSV:0;
X-Mail-Gray	1
X-Abs-Checked	4
X-Rl-Sender	david.wu@rock-chips.com
X-Fst-To	linux-kernel@vger.kernel.org
X-Sender-IP	58.22.7.114
X-Login-Name	david.wu@rock-chips.com
X-Unique-Tag	<74939f854751cb6fab82ca80bb02e811>
X-Sender	wdc@rock-chips.com
User-Agent	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version	1.0
Content-Type	text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	8
Organization	linux.* mail to news gateway
X-Original-Cc	thierry.reding@gmail.com, heiko@sntech.de, robh+dt@kernel.org, catalin.marinas@arm.com, briannorris@chromium.org, dianders@chromium.org, mark.rutland@arm.com, huangtao@rock-chips.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 4 Jul 2017 15:37:54 +0800
X-Original-Message-ID	<05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com>
X-Original-References	<1498739271-27431-1-git-send-email-david.wu@rock-chips.com> <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> <20170703203957.03f3d1db@bbrezillon>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1680722

Show key headers only | View raw

Hi Boris,

在 2017/7/4 2:39, Boris Brezillon 写道:
> Yet another customization. Don't you think we can extract common parts,
> expose them as helpers and then have 3 different pwm_ops (with 3
> different ->apply() implementation), one for each IP revision.

Sounds reasonable.I will try to implement 3 different apply().

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for  rk3328 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-07-03 20:50 +0200
  Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 "David.Wu" <david.wu@rock-chips.com> - 2017-07-04 09:40 +0200

csiph-web