[PATCH] char: ipmi: eliminate misleading print info when being probed via ACPI

From	Hanjun Guo <guohanjun@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] char: ipmi: eliminate misleading print info when being probed via ACPI
Date	2017-07-04 06:20 +0200
Message-ID	<tZntD-33x-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Hanjun Guo <hanjun.guo@linaro.org>

When ipmi is probed via ACPI, the boot log shows

[   17.945139] ipmi_si IPI0001:00: probing via device tree
[   17.950369] ipmi_si IPI0001:00: ipmi_si: probing via ACPI
[   17.955795] ipmi_si IPI0001:00: [io  0x00e4-0x3fff] regsize 1 spacing 1 irq 0
[   17.962932] ipmi_si: Adding ACPI-specified bt state machine

which "ipmi_si IPI0001:00: probing via device tree" is misleading
with a ACPI HID "IPI0001" but probing via DT.

Eliminate this misleading print info by checking of_node is valid
or not before calling of_ipmi_probe().

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 drivers/char/ipmi/ipmi_si_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 59ee93e..159950d 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2810,7 +2810,7 @@ static int acpi_ipmi_probe(struct platform_device *dev)
 
 static int ipmi_probe(struct platform_device *dev)
 {
-	if (of_ipmi_probe(dev) == 0)
+	if (dev->dev.of_node && of_ipmi_probe(dev) == 0)
 		return 0;
 
 	return acpi_ipmi_probe(dev);
-- 
1.7.12.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] char: ipmi: eliminate misleading print info when being probed via ACPI Hanjun Guo <guohanjun@huawei.com> - 2017-07-04 06:20 +0200

csiph-web