Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is unsupported tests

From	Masami Hiramatsu <mhiramat@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is unsupported tests
Date	2017-07-04 02:40 +0200
Message-ID	<tZk2J-Cc-3@gated-at.bofh.it> (permalink)
References	<tZ25Q-51u-7@gated-at.bofh.it> <tZ9qH-1XI-25@gated-at.bofh.it> <tZbVv-3vu-1@gated-at.bofh.it> <tZbVv-3vu-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 3 Jul 2017 11:59:06 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 4 Jul 2017 00:52:32 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > 
> > > 
> > > Can we add an option in kselftest, or to ftracetest that decides if
> > > unsupported is a failure or not? Otherwise I can not ack this patch.  
> > 
> > I would rather like to add an option to ftracetest instead of
> > kselftest, because whether the tested feature should be supported
> > or not is hard to decide from testing framework. It should be
> > checked by manual.
> 
> Can we do both? That is, add an option to have ftracetest not fail on
> "unsupported" but have it fail by default. We can have kselftest just
> pass in a parameter to ftracetest that has unsupported not fail?

I rather like to treat unsupported as success (or XFAIL) by default
and add "--fail-unsupported" option.

Thank you,

> But if that is too difficult, then I can live with modifying my test
> case to add the option.
> 
> -- Steve


-- 
Masami Hiramatsu <mhiramat@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is  unsupported tests Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-03 18:00 +0200
  Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is  unsupported tests Steven Rostedt <rostedt@goodmis.org> - 2017-07-03 18:00 +0200
    Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is  unsupported tests Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-04 02:40 +0200

csiph-web