Re: [PATCH v2] drm: tilcdc: tilcdc_tfp410: make of_device_ids const.

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Jyri Sarha <jsarha@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drm: tilcdc: tilcdc_tfp410: make of_device_ids const.
Date	Mon, 03 Jul 2017 22:40:01 +0200
Message-ID	<tZgit-6Gt-7@gated-at.bofh.it> (permalink)
References	<tXe1r-2Mb-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1499114207; bh=JR+FZmxXWsjSOIyW5GKODmVih3ZtbhC436OTfAQsgR0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=aW8I07rUBasv9ISf7I+/Z1KOITLwi7jDv7JnCN0fGJXpNgvDtdOowmmvh/xK8ppU4 TRhMnzrbACNRRRbNRz7xz4wAQ88hiy26XdZZULxd99cbt09fi9ea/1a801GfQaP7bQ o492otkNLbUqhvoQn7INY3bgXNY9EFozHoiGqnnw=
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Language	en-GB
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 3 Jul 2017 23:36:45 +0300
X-Original-Message-ID	<a143234a-b482-cb58-9ed2-8019baf503f7@ti.com>
X-Original-References	<c26d4f2a89e7658942f903f4a25f002135cf6c6a.1498628403.git.arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1680560

Show key headers only | View raw

On 06/28/17 08:42, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    1496	    592	      0	   2088	    828	drivers/gpu/drm/tilcdc/tilcdc_tfp410.o
> 
> File size after constify:
>    text	   data	    bss	    dec	    hex	filename
>    1880	    176	      0	   2056	    808	drivers/gpu/drm/tilcdc/tilcdc_tfp410.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>


Thanks, I pick this up and push it in next merge window (for 4.14).
However, both this and the bundled panel driver is going away as soon as
I have time to do it, but it is unlikely to happen before v4.14.

Best regards,
Jyri


> ---
> Changes in v1:
>               Subject was not correct.
> 
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index aabfad8..236ca1e 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -290,8 +290,6 @@ static int tfp410_modeset_init(struct tilcdc_module *mod, struct drm_device *dev
>   * Device:
>   */
>  
> -static struct of_device_id tfp410_of_match[];
> -
>  static int tfp410_probe(struct platform_device *pdev)
>  {
>  	struct device_node *node = pdev->dev.of_node;
> @@ -376,7 +374,7 @@ static int tfp410_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct of_device_id tfp410_of_match[] = {
> +static const struct of_device_id tfp410_of_match[] = {
>  		{ .compatible = "ti,tilcdc,tfp410", },
>  		{ },
>  };
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] drm: tilcdc: tilcdc_tfp410: make of_device_ids const. Jyri Sarha <jsarha@ti.com> - 2017-07-03 22:40 +0200

csiph-web