Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem
Date	2017-07-03 18:40 +0200
Message-ID	<tZcyf-40A-41@gated-at.bofh.it> (permalink)
References	<tXKkF-1nd-19@gated-at.bofh.it> <tY0ps-3C8-1@gated-at.bofh.it> <tY1bQ-4cr-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 30-06-17 12:15:21, Thomas Gleixner wrote:
[...]
> Sure. Just to make you to mull over more stuff, find below the patch which
> moves all of this to use the cpuhotplug lock.
> 
> Thanks,
> 
> 	tglx
> 
> 8<--------------------
> Subject: mm/memory-hotplug: Use cpu hotplug lock
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Thu, 29 Jun 2017 16:30:00 +0200
> 
> Most place which take the memory hotplug lock take the cpu hotplug lock as
> well. Avoid the double locking and use the cpu hotplug lock for both.

Hmm, I am usually not a fan of locks conflating because it is then less
clear what the lock actually protects. Memory and cpu hotplugs should
be largely independent so I am not sure this patch simplify things a
lot. It is nice to see few lines go away but I am little bit worried
that we will enventually develop a separate locking again in future for
some weird memory hotplug usecases.

> Not-Yet-Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
[...]
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
[...]
> @@ -2138,7 +2114,7 @@ void __ref remove_memory(int nid, u64 st
>  
>  	try_offline_node(nid);
>  
> -	mem_hotplug_done();
> +	cpus_write_lock();

unlock you meant here, right?

-- 
Michal Hocko
SUSE Labs

Thread

[PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Thomas Gleixner <tglx@linutronix.de> - 2017-06-29 18:20 +0200
  Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Michal Hocko <mhocko@kernel.org> - 2017-06-30 11:30 +0200
    Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Thomas Gleixner <tglx@linutronix.de> - 2017-06-30 12:20 +0200
      Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Thomas Gleixner <tglx@linutronix.de> - 2017-06-30 15:10 +0200
      Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Michal Hocko <mhocko@kernel.org> - 2017-07-03 18:40 +0200
        Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Thomas Gleixner <tglx@linutronix.de> - 2017-07-03 22:00 +0200
  Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-07-03 14:50 +0200
  Re: [PATCH] mm/memory-hotplug: Switch locking to a percpu rwsem Michal Hocko <mhocko@kernel.org> - 2017-07-03 18:40 +0200

csiph-web