Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1680471

Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory initially

From "Jan Beulich" <JBeulich@suse.com>
Newsgroups linux.kernel
Subject Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory initially
Date 2017-07-03 18:20 +0200
Message-ID <tZceS-3TE-5@gated-at.bofh.it> (permalink)
References <tZbLP-3s5-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>>> On 03.07.17 at 17:40, <jgross@suse.com> wrote:
> --- a/drivers/xen/xen-balloon.c
> +++ b/drivers/xen/xen-balloon.c
> @@ -59,6 +59,8 @@ static void watch_target(struct xenbus_watch *watch,
>  {
>  	unsigned long long new_target;
>  	int err;
> +	static bool watch_fired;
> +	static unsigned long target_diff;

It would seem to me that the types of target_diff and new_target
should match in width, but differ in signedness.

Jan

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] xen/balloon: don't online new memory initially Juergen Gross <jgross@suse.com> - 2017-07-03 17:50 +0200
  Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory  initially "Jan Beulich" <JBeulich@suse.com> - 2017-07-03 18:20 +0200
  Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory  initially Juergen Gross <jgross@suse.com> - 2017-07-03 18:20 +0200
  Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory  initially Igor Druzhinin <igor.druzhinin@citrix.com> - 2017-07-03 20:50 +0200
    Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory  initially Juergen Gross <jgross@suse.com> - 2017-07-04 07:50 +0200

csiph-web