[PATCH 02/15] perf tests attr: Do not store failed events

From	Jiri Olsa <jolsa@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 02/15] perf tests attr: Do not store failed events
Date	2017-07-03 17:00 +0200
Message-ID	<tZaZu-2UC-87@gated-at.bofh.it> (permalink)
References	<tZaZr-2UC-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Do not mess up our temp space with files we don't
need - failed event open attempts.

Link: http://lkml.kernel.org/n/tip-gfmm0o2bidc41umvecbtsf36@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/tests/attr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c
index 0e77b2cf61ec..08b1d5ce9020 100644
--- a/tools/perf/tests/attr.c
+++ b/tools/perf/tests/attr.c
@@ -136,7 +136,7 @@ void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu,
 {
 	int errno_saved = errno;
 
-	if (store_event(attr, pid, cpu, fd, group_fd, flags)) {
+	if ((fd != -1) && store_event(attr, pid, cpu, fd, group_fd, flags)) {
 		pr_err("test attr FAILED");
 		exit(128);
 	}
-- 
2.9.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 02/15] perf tests attr: Do not store failed events Jiri Olsa <jolsa@kernel.org> - 2017-07-03 17:00 +0200

csiph-web