[PATCH v2 01/37] Revert "android: binder: Sanity check at binder ioctl"

Path	csiph.com!goblin1!goblin3!goblin.stu.neva.ru!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Todd Kjos <tkjos@android.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 01/37] Revert "android: binder: Sanity check at binder ioctl"
Date	Wed, 05 Jul 2017 22:50:02 +0200
Message-ID	<tZZpg-2RM-29@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=from:to:subject:date:message-id; bh=xoSUFV2k4Aylm4TAGKBldlEaxlkHPWQUAZILWcPxfds=; b=V7ipz1H2w2fRiUhEp+JQfRvb+oxQOItHW8HaPegv+O5y4wYKlAx2nx7/wblYVD2ajK t84MEsJrfzSY38kxRhye4Jm3PLBp4wzklKtpzC5v31dS5sfp09Rc7del7qw+OhJfZKMN qwfTWYdv9hmIy0FHZ/wqfo+CWQTWcFLDAJYz3uIdFllz7YZ2ga3owhZ8HUZ83NGdLNfq 2X41dNMrelvwDt3XsJggqkms0wIF0NSfw0Lr4JGz8MwC0Vm16mXVDCs3zWJ9Boubg10V RR5eaTPbOZRvm247JS3aDqOynrFHC6CAUqntJ4revSptZ+3+EkN+tBgbK5LolFgJDZ4E T0kw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=xoSUFV2k4Aylm4TAGKBldlEaxlkHPWQUAZILWcPxfds=; b=k1XqVojUcq3uMfC5yL7G+PDOtubKZdnsfLq2c11VhLJa8U+FXlLx1vmyrBtaEHellO nGvNIWJq14ta6Dh1Lykg4OA0umufT6skTt7IpB51wUNUSjrutbpHOroZGvh1K4RcJdtp q1tKDa57GE/GvZkZ4HCjnvs2qiKjyyBDqv8zNVgeVm2Uy7Lwu2pim7oe4ZvDd8za3+ip ZjaFCV6RMJvKIwZ7wf0g8gACGCR9jI0VeQ/tdfXotNn5ChH5jqdjYYuSNMhI2Tc1nl2O 9duRasRocNbjtN2yHb/WIqkjxhLfGHBDcLGTMARIqDnLKJ+o7XDYa2TpKyIIh3jm56ee Lt6Q==
X-Gm-Message-State	AIVw112+a90cTWg38sxIcbt28fKffamQaaxIunuZa0arLlPO17GOzjlo xjvfYe/wFI+bAOlD
X-Received	by 10.84.132.40 with SMTP id 37mr9247933ple.178.1499287572538; Wed, 05 Jul 2017 13:46:12 -0700 (PDT)
X-Google-Original-From	Todd Kjos <tkjos@google.com>
X-Mailer	git-send-email 2.13.2.725.g09c95d1e9-goog
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Date	Wed, 5 Jul 2017 13:46:01 -0700
X-Original-Message-ID	<20170705204601.35566-1-tkjos@google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1681799

Show key headers only | View raw

This reverts commit a906d6931f3ccaf7de805643190765ddd7378e27.

The patch introduced a race in the binder driver. An attempt to fix the
race was submitted in "[PATCH v2] android: binder: fix dangling pointer
comparison", however the conclusion in the discussion for that patch
was that the original patch should be reverted.

The reversion is being done as part of the fine-grained locking
patchset since the patch would need to be refactored when
proc->vmm_vm_mm is removed from struct binder_proc and added
in the binder allocator.

Also needs reversion in 4.9 LTS

Signed-off-by: Todd Kjos <tkjos@google.com>
---
 drivers/android/binder.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index aae4d8d4be36..157bd3e49ff4 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3247,10 +3247,6 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
 			proc->pid, current->pid, cmd, arg);*/
 
-	if (unlikely(current->mm != proc->vma_vm_mm)) {
-		pr_err("current mm mismatch proc mm\n");
-		return -EINVAL;
-	}
 	trace_binder_ioctl(cmd, arg);
 
 	ret = wait_event_interruptible(binder_user_error_wait, binder_stop_on_user_error < 2);
@@ -3466,7 +3462,6 @@ static int binder_open(struct inode *nodp, struct file *filp)
 		return -ENOMEM;
 	get_task_struct(current);
 	proc->tsk = current;
-	proc->vma_vm_mm = current->mm;
 	INIT_LIST_HEAD(&proc->todo);
 	init_waitqueue_head(&proc->wait);
 	proc->default_priority = task_nice(current);
-- 
2.13.2.725.g09c95d1e9-goog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 01/37] Revert "android: binder: Sanity check at binder ioctl" Todd Kjos <tkjos@android.com> - 2017-07-05 22:50 +0200

csiph-web