Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681745

Re: [PATCH v2] alarmtimer: Fix unavailable wake-up source in sysfs

Show all headers | View raw

On Wed, Jul 5, 2017 at 5:08 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Currently the alarmtimer registers a wake-up source unconditionally,
> regardless of the system having a (wake-up capable) RTC or not.
> Hence the alarmtimer will always show up in
> /sys/kernel/debug/wakeup_sources, even if it is not available, and thus
> cannot be a wake-up source.
>
> To fix this, postpone registration until a wake-up capable RTC device is
> added.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Move ws inside #ifdef CONFIG_RTC_CLASS to avoid a defined but not
>     used warning if CONFIG_RTC_CLASS is disabled,
>   - Reword.


This looks ok to me. I've queued it up for testing, targeting 4.14.
Let me know if its more urgent.

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] alarmtimer: Fix unavailable wake-up source in sysfs Geert Uytterhoeven <geert+renesas@glider.be> - 2017-07-05 14:10 +0200
  Re: [PATCH v2] alarmtimer: Fix unavailable wake-up source in sysfs John Stultz <john.stultz@linaro.org> - 2017-07-05 21:50 +0200

csiph-web