Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events

From	Benson Leung <bleung@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events
Date	2017-07-05 22:20 +0200
Message-ID	<tZYWd-2G9-7@gated-at.bofh.it> (permalink)
References	<taRqx-62G-3@gated-at.bofh.it> <taRqy-62G-5@gated-at.bofh.it> <tX1xg-32b-29@gated-at.bofh.it> <tZ81A-MT-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Lee,

On Mon, Jul 03, 2017 at 12:46:41PM +0100, Lee Jones wrote:
> On Tue, 27 Jun 2017, Benson Leung wrote:
> 
> > Hi Thierry,
> > 
> > On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote:
> > > From: Shawn Nematbakhsh <shawnn@chromium.org>
> > > 
> > > The subset of wake-enabled host events is defined by the EC, but the EC
> > > may still send non-wake host events if we're in the process of
> > > suspending. Get the mask of wake-enabled host events from the EC and
> > > filter out non-wake events to prevent spurious aborted suspend
> > > attempts.
> > > 
> > > Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
> > > Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
> > > ---
> > >  drivers/mfd/cros_ec.c                   | 13 ++++--
> > >  drivers/platform/chrome/cros_ec_proto.c | 76 ++++++++++++++++++++++++++++++---
> > >  include/linux/mfd/cros_ec.h             |  5 ++-
> > >  3 files changed, 85 insertions(+), 9 deletions(-)
> > > 
> > 
> > Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since
> > this patch was posted, so I went ahead and modified that too.
> > 
> > Applied. Thanks.
> 
> No need to change anything this time, but please note the "for my own
> reference" in my Ack in future.  It typically means that I plan on
> pushing it through the MFD tree or that it requires further discussion
> (in the case that another Maintainer would prefer it go through their
> tree).
> 

Sorry about that. Thanks for the advice! I'm still getting my sea legs for
maintainership.

Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake  host events Benson Leung <bleung@google.com> - 2017-07-05 22:20 +0200
  Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake  host events Lee Jones <lee.jones@linaro.org> - 2017-07-06 09:20 +0200

csiph-web