Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681644

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"
Date 2017-07-05 18:30 +0200
Message-ID <tZVlF-aF-35@gated-at.bofh.it> (permalink)
References <tZpF8-4BK-9@gated-at.bofh.it> <tZpF8-4BK-11@gated-at.bofh.it> <tZVlE-aF-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, 5 Jul 2017 12:25:06 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

 
> > @@ -255,12 +262,18 @@ __run_test() { # testfile
> >  # Run one test case
> >  run_test() { # testfile
> >    local testname=`basename $1`
> > -  local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > +  if [ "$LOG_FILE" ] ; then  
> 
> Shouldn't this be
> 
> 	if [ ! -z "$LOG_FILE" ]; then
> 
> ?
> 

OK, I just checked it out. I guess "" is considered zero and
"<anything>" is considered 1.

Hmm, do we do this in other places too. Just makes me unconfortable.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-04 08:40 +0200
  Re: [PATCH 4/4] selftests: ftrace: Output only to console with  "--logdir -" Steven Rostedt <rostedt@goodmis.org> - 2017-07-05 18:30 +0200
    Re: [PATCH 4/4] selftests: ftrace: Output only to console with  "--logdir -" Steven Rostedt <rostedt@goodmis.org> - 2017-07-05 18:30 +0200
      Re: [PATCH 4/4] selftests: ftrace: Output only to console with  "--logdir -" Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-06 08:10 +0200
    Re: [PATCH 4/4] selftests: ftrace: Output only to console with  "--logdir -" Stafford Horne <shorne@gmail.com> - 2017-07-06 15:10 +0200
      Re: [PATCH 4/4] selftests: ftrace: Output only to console with  "--logdir -" Steven Rostedt <rostedt@goodmis.org> - 2017-07-06 15:20 +0200
      Re: [PATCH 4/4] selftests: ftrace: Output only to console with  "--logdir -" Masami Hiramatsu <mhiramat@kernel.org> - 2017-07-07 02:50 +0200

csiph-web