Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

From	Vincent Legout <vincent.legout@gandi.net>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device
Date	2017-07-05 15:40 +0200
Message-ID	<tZSH8-6Md-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <tZzl7-2yf-5@gated-at.bofh.it> <tZNxM-3Ho-21@gated-at.bofh.it> <tZNHr-3KF-7@gated-at.bofh.it> <tZRL3-6dL-3@gated-at.bofh.it> <tZS4p-6k6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 05, 2017 at 06:53:25AM -0600, Jan Beulich wrote :
> >>> On 05.07.17 at 14:37, <vincent.legout@gandi.net> wrote:
> > On Wed, Jul 05, 2017 at 02:17:24AM -0600, Jan Beulich wrote :
> >> >>> On 05.07.17 at 10:08, <vincent.legout@gandi.net> wrote:
> >> > Without the patch, blkif_release and xlvbd_release_gendisk are never
> >> > called, and no call to blk_unregister_queue is made.
> >> 
> >> But isn't that what needs to be fixed then? The device should be
> >> removed once its last user goes away (which would be at the time
> >> the umount is eventually done aiui).
> > 
> > You mean that block-detach should fail if the device is still mounted?
> > or find a way to wait until all the users are gone?
> > 
> > I don't say that's not what should be done, but that's not what I get.
> > The device is removed after a block-detach, even if still mounted. So
> > the system is left in an unstable state without the patch.
> 
> Unstable? I'd expect subsequent I/O to fail for that device, yes, but
> that's still a stable system. Are you observing anything else?

Yes, that's what I meant by unstable, nothing else. Sorry for the
confusion.

Vincent

Thread

[PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device Vincent Legout <vincent.legout@gandi.net> - 2017-07-04 14:00 +0200
  Re: [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching  device Roger Pau Monné <roger.pau@citrix.com> - 2017-07-04 19:00 +0200
    Re: [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching  device Vincent Legout <vincent.legout@gandi.net> - 2017-07-05 10:10 +0200
      Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent  when detaching device "Jan Beulich" <JBeulich@suse.com> - 2017-07-05 10:20 +0200
        Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when  detaching device Vincent Legout <vincent.legout@gandi.net> - 2017-07-05 14:40 +0200
          Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent  when detaching device "Jan Beulich" <JBeulich@suse.com> - 2017-07-05 15:00 +0200
            Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when  detaching device Vincent Legout <vincent.legout@gandi.net> - 2017-07-05 15:40 +0200
              Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when  detaching device Roger Pau Monné <roger.pau@citrix.com> - 2017-07-07 10:20 +0200

csiph-web