[PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits
Date	Wed, 05 Jul 2017 12:40:02 +0200
Message-ID	<tZPSW-537-1@gated-at.bofh.it> (permalink)
X-Original-To	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=aX8LBO+5PnXdeh0ca5KkUKACnXbda7uX3SL1jM7bYuU=; b=XsZCQjt0i2LqPT1mCk4TSUDMuWX+3ebwq9qp4JwOWnyVCeW8NZnsTyRfhuGHOrr16x LJ+nMw+FEsQAQdDO00hd079TWez6XdQopTA5KNGRrd9TrcQalqp9PjaXSqVoeM/BhHBZ drFbAW7D7l/5m8aKQrxWDiC8ODkEk4bLQAndFMp84/OljB1CB/GaKTi3vkLqzIgJ6x6Y aLCROqQRSdW6j1ALrrG7hz4MuToXo5q2w6/1P6DuXQ/MJE5j3McZnlaX+jRsCUCSfZOZ ofzoxk4bzzZ5e5sQIjDTri6gs1AlkvJwfEb2aGaEitmXBem4jtHyJPpwXAe/lwDGMY22 sSZQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=aX8LBO+5PnXdeh0ca5KkUKACnXbda7uX3SL1jM7bYuU=; b=aZ+Kng4JYJP6spJRjXYs2SO3KqRWBgU55wyNtRpP9jklJjpLtt9SlP2XhPU+y3XQO2 NSz73OnYdstqhX0tg90gyi3K3cFHXBJgKIJRd7jc2CHzJ/mRslCey7jldLMF2fp8s3W+ g3eJItuN9KboreUX9i+Y0/9XeM3Qng/lek2q5z1wMedGUQJNKdn8yV2eVCQ5TvP9WFmZ ykxWJgEzsBtq9p9s53Z7vIu5IsrgyTVr/hwCmAlJoVEYszZdYdvStwYzDN9Z5pAZKMap qARmZ90OGuKBa6rWwUdh6wcr0nnK5mzVlyDNlqoWrKyGUX9WHBuSYq8vXN6CprC4au0l gtfw==
X-Gm-Message-State	AKS2vOwegLu+lb0KjaZ+uy1rXgakj8JMlkZ63hGJJNkj0Erg3mYt0B1a 8EzzE3iJGjW9s18YRNQ=
X-Received	by 10.223.176.218 with SMTP id j26mr38809130wra.192.1499251127053; Wed, 05 Jul 2017 03:38:47 -0700 (PDT)
X-Mailer	git-send-email 1.8.3.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Date	Wed, 5 Jul 2017 12:38:44 +0200
X-Original-Message-ID	<1499251124-35803-1-git-send-email-pbonzini@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1681442

Show key headers only | View raw

This exit ended up being reported, but the currently exposed data does not provide
much of a starting point for debugging.  In the reported case, the vmexit was
an EPT misconfiguration (MMIO access).  Let userspace report ethe exit qualification
and, if relevant, the GPA.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 arch/x86/kvm/vmx.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 6dcc4873e435..4be80c3ac24d 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -8408,9 +8408,15 @@ static int vmx_handle_exit(struct kvm_vcpu *vcpu)
 			exit_reason != EXIT_REASON_TASK_SWITCH)) {
 		vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
 		vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_DELIVERY_EV;
-		vcpu->run->internal.ndata = 2;
+		vcpu->run->internal.ndata = 3;
 		vcpu->run->internal.data[0] = vectoring_info;
 		vcpu->run->internal.data[1] = exit_reason;
+		vcpu->run->internal.data[2] = vcpu->arch.exit_qualification;
+		if (exit_reason == EXIT_REASON_EPT_MISCONFIG) {
+			vcpu->run->internal.ndata++;
+			vcpu->run->internal.data[3] =
+				vmcs_read64(GUEST_PHYSICAL_ADDRESS);
+		}
 		return 0;
 	}
 
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits Paolo Bonzini <pbonzini@redhat.com> - 2017-07-05 12:40 +0200
  Re: [PATCH] KVM: vmx: expose more information for  KVM_INTERNAL_ERROR_DELIVERY_EV exits David Hildenbrand <david@redhat.com> - 2017-07-05 14:30 +0200
    Re: [PATCH] KVM: vmx: expose more information for  KVM_INTERNAL_ERROR_DELIVERY_EV exits Paolo Bonzini <pbonzini@redhat.com> - 2017-07-05 14:30 +0200

csiph-web