Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681141

[BUG] checkpatch: false positive storage class location

Show all headers | View raw

The U-Boot project uses the same scripts/checkpatch.pl as the Linux
kernel. I ran upon the problem below when working on U-Boot. But I
guess it should be fixed in the Linux upstream.

Running checkpatch for this email produces
WARNING: storage class should be at the beginning of the declaration

This relates to the parameter with asmlinkage.

asmlinkage is at the start of the parameter so I think this a false
positive.

Signed-off-by: Heinrich.Schuchardt <xypron.glpk@gmx.de>
---

 cmd/bootefi.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index 771300ee94..4df468307c 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -147,6 +147,12 @@ static void *copy_fdt(void *fdt)
 	return new_fdt;
 }
 
+static ulong efi_do_enter(void *image_handle,
+		struct efi_system_table *st, asmlinkage ulong (*entry)(
+		void *image_handle, struct efi_system_table *st))
+{
+	return 0;
+}
+
 /*
 end
 */
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[BUG] checkpatch: false positive storage class location Heinrich Schuchardt <xypron.glpk@gmx.de> - 2017-07-04 21:30 +0200
  Re: [BUG] checkpatch: false positive storage class location Joe Perches <joe@perches.com> - 2017-07-04 22:50 +0200
    Re: [BUG] checkpatch: false positive storage class location Heinrich Schuchardt <xypron.glpk@gmx.de> - 2017-07-04 23:10 +0200
      Re: [BUG] checkpatch: false positive storage class location Joe Perches <joe@perches.com> - 2017-07-05 14:10 +0200

csiph-web