Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support
Date	2017-07-04 20:20 +0200
Message-ID	<tZAAx-3tZ-1@gated-at.bofh.it> (permalink)
References	(5 earlier) <tWGsN-5pf-7@gated-at.bofh.it> <tXieK-5vN-17@gated-at.bofh.it> <tXERY-6nj-11@gated-at.bofh.it> <tZxMm-1ET-21@gated-at.bofh.it> <tZxW2-1JA-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 4, 2017 at 5:28 PM, Takashi Iwai <tiwai@suse.de> wrote:
> On Tue, 04 Jul 2017 17:14:39 +0200,
> Daniel Vetter wrote:
>> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
>> >> Now I took a closer look, and this appears rather like a brown paper
>> >> bag bug, not about the deferred probe or module dependency.
>> >> The fix patch is below.  Could you check whether it works?
>> >
>> > Yay, this works!
>> >
>> > Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> Next one: i915 module reloading is broken because something is holding
>> onto a module reference and doesn't drop it. Didn't check which sets
>> of patches introduced this, but iirc this worked last week. Disabling
>> hda-intel gets in Kconfig gets rid of the problem, so I assume
>> something in the sound driver is leaking that reference ...
>>
>> It's also causing lots and lots of red in our CI :( If we can't fix
>> this we need to disable snd-hda-intel there too.
>
> I spotted out a typo in my previous patch that leads to the module
> reference unbalance.  The fix is  already in sound.git tree today:
>   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795
>
> The bug was introduced after 4.12.

Ok, CI over here confirmed that it's all good again.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support Daniel Vetter <daniel@ffwll.ch> - 2017-07-04 17:20 +0200
  Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support Takashi Iwai <tiwai@suse.de> - 2017-07-04 17:30 +0200
    Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support Daniel Vetter <daniel@ffwll.ch> - 2017-07-04 20:20 +0200

csiph-web