Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679892

Re: [PATCH] gpiolib: skip unwanted events, don't convert them to opposite edge

Show all headers | View raw

On Mon, Jul 3, 2017 at 12:12 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> The previous fix for filtering out of unwatched events was not entirely
> correct. Instead of skipping the events we don't want, they are now
> interpreted as events with opposing edge.
>
> In order to fix it: always read the GPIO line value on interrupt and
> only emit the event if it corresponds with the event type we requested.

>         struct lineevent_state *le = p;
>         struct gpioevent_data ge;
> -       int ret;
> +       int ret, level;

I prefer
int level;
int ret;

Though it's matter of taste (I don't remember which one Linus' preferable).

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpiolib: skip unwanted events, don't convert them to opposite edge Bartosz Golaszewski <brgl@bgdev.pl> - 2017-07-03 11:20 +0200
  Re: [PATCH] gpiolib: skip unwanted events, don't convert them to  opposite edge Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-03 13:10 +0200
    Re: [PATCH] gpiolib: skip unwanted events, don't convert them to  opposite edge Bartosz Golaszewski <brgl@bgdev.pl> - 2017-07-04 16:30 +0200

csiph-web