Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679919
| From | Jon Hunter <jonathanh@nvidia.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() |
| Date | 2017-07-03 13:40 +0200 |
| Message-ID | <tZ7RT-J4-3@gated-at.bofh.it> (permalink) |
| References | <tXYxk-2tg-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 30/06/17 08:22, Gustavo A. R. Silva wrote:
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/devfreq/tegra-devfreq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
> index 214fff9..ae71215 100644
> --- a/drivers/devfreq/tegra-devfreq.c
> +++ b/drivers/devfreq/tegra-devfreq.c
> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ\n");
> - return -ENODEV;
> + if (irq < 0) {
The changelog does not describe the above change and if/why this is ok.
However, the original test looks fine to me and so I don't see a need to
change this.
> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
> + return irq;
Why not have ...
return irq ? irq : -ENODEV;
Cheers
Jon
--
nvpublic
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 09:30 +0200
Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Chanwoo Choi <cw00.choi@samsung.com> - 2017-06-30 10:10 +0200
Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-07-01 09:50 +0200
Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Jon Hunter <jonathanh@nvidia.com> - 2017-07-03 13:40 +0200
Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-03 14:00 +0200
Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Jon Hunter <jonathanh@nvidia.com> - 2017-07-03 14:30 +0200
[PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-03 14:50 +0200
Re: [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() Jon Hunter <jonathanh@nvidia.com> - 2017-07-04 10:40 +0200
Re: [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 07:00 +0200
csiph-web