Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679789

Re: [PATCH] cpufreq: cpufreq_stats: constify attribute_group structures.

Show all headers | View raw

On 03-07-17, 13:29, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    1655	    256	      4	   1915	    77b	drivers/cpufreq/cpufreq_stats.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    1695	    192	      4	   1891	    763	drivers/cpufreq/cpufreq_stats.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/cpufreq/cpufreq_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> index f570ead..d362739 100644
> --- a/drivers/cpufreq/cpufreq_stats.c
> +++ b/drivers/cpufreq/cpufreq_stats.c
> @@ -135,7 +135,7 @@ static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf)
>  	&trans_table.attr,
>  	NULL
>  };
> -static struct attribute_group stats_attr_group = {
> +static const struct attribute_group stats_attr_group = {
>  	.attrs = default_attrs,
>  	.name = "stats"
>  };

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: cpufreq_stats: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-03 10:00 +0200
  Re: [PATCH] cpufreq: cpufreq_stats: constify attribute_group  structures. Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-03 11:10 +0200

csiph-web