Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679774
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low |
| Date | 2017-07-03 11:00 +0200 |
| Message-ID | <tZ5n3-78c-11@gated-at.bofh.it> (permalink) |
| References | <tXrUK-29U-23@gated-at.bofh.it> <tXrUK-29U-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Jim Baxter <jim_baxter@mentor.com> Date: Wed, 28 Jun 2017 21:35:29 +0100 > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the throughput of CDC-NCM with 16KiB > NTB's. > > The issue is after running for a while the kernel memory can become > fragmented and it needs compacting. > If the NTB allocation is needed before the memory has been compacted > the atomic allocation can fail which can cause increased latency, > large re-transmissions or disconnections depending upon the data > being transmitted at the time. > This situation occurs for less than a second until the kernel has > compacted the memory but the failed devices can take a lot longer to > recover from the failed TX packets. > > To ease this temporary situation I modified the CDC-NCM TX path to > temporarily switch into a reduced memory mode which allocates an NTB > that will fit into a USB_CDC_NCM_NTB_MIN_OUT_SIZE (default 2048 Bytes) > sized memory block and only transmit NTB's with a single network frame > until the memory situation is resolved. > Each time this issue occurs we wait for an increasing number of > reduced size allocations before requesting a full size one to not > put additional pressure on a low memory system. > > Once the memory is compacted the CDC-NCM data can resume transmitting > at the normal tx_max rate once again. > > Signed-off-by: Jim Baxter <jim_baxter@mentor.com> Patch applied, thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Jim Baxter <jim_baxter@mentor.com> - 2017-06-28 22:40 +0200
Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low "Baxter, Jim" <jim_baxter@mentor.com> - 2017-06-30 19:10 +0200
Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low David Miller <davem@davemloft.net> - 2017-06-30 19:10 +0200
Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Bjørn Mork <bjorn@mork.no> - 2017-06-30 19:40 +0200
Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low "Baxter, Jim" <jim_baxter@mentor.com> - 2017-06-30 20:00 +0200
Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Bjørn Mork <bjorn@mork.no> - 2017-06-30 20:10 +0200
Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low David Miller <davem@davemloft.net> - 2017-07-03 11:00 +0200
csiph-web