Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay
Date	Mon, 03 Jul 2017 10:50:03 +0200
Message-ID	<tZ5do-74o-29@gated-at.bofh.it> (permalink)
References	<tXKXo-1AK-19@gated-at.bofh.it> <tXKXo-1AK-21@gated-at.bofh.it> <tYC1I-2Ms-5@gated-at.bofh.it> <tYCl3-2SW-9@gated-at.bofh.it> <tZ47E-6mA-17@gated-at.bofh.it> <tZ4AH-6PE-33@gated-at.bofh.it> <tZ4Km-6Tf-9@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wjneva6N9BW7IsVZyg9jh77rKo32t7hnOapnI8O62OI=; b=qTFKLjQmWgIXTBhP9E/14KVm6/dYb1EalZWPqnAH14ooQnlE9BBo8l5kBzv7ZCGPF9 ZmTSTID5cvKRtzdvhE3L5kb0x6tJwOqg7K/MFAfsiC73owagSI5vgI29tb551rT/kP+H eAt8hIKDJntPjn8b89ayLEjFSL3znlUoLmpOB8ub4eHoGvcabD4l4mAsWeRlRhnMic3P t/ztv7bJBWBPlmM0pxE3vn825hB0yE4NNbsYtMwnnsswxnHAvp0GxPtwWhR1PQh/YIQS 8oYNZ4beOtH8c44sSWyVYXEkq2jTYL922JZ37+yGizvGiDyL1t1fG+RSqC1RFY2KXBx+ aT9A==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wjneva6N9BW7IsVZyg9jh77rKo32t7hnOapnI8O62OI=; b=hsXuqXMzxrz8SM1tnO6LK17GWccdwTXRc0Q1MjCk8uPJGtoOS0FNOZ2Sj04nshtlJq BKgi2EtJ6+oQzjjNaAqzvENmjRxGoBJbxgh2NN+uNg/9HeQ8zHD9ExqKkntJ2fequMF8 1Nob0r4wgFzptp2ZAxuFSQgoCd2eEOaFtCtXO/oEjKfP95sBTTk/6EiHgaPFsSo9/DTt Uef5HAcwvfNJfFkDnv27ip4EOFj4ddWl00egVQEiubcuk5YIuup+Lh+GRQBRBTlGfpen GD79IaZAlcMrBwoF+cGweBcdIo1A9Go2ydmuqcn6X+OQDoER+RpZaSK/ROwKGHnEvkeq RkXw==
X-Gm-Message-State	AKS2vOwW2uRxjXsup9LRA3KWtIhiyXSbPZ62oP6vXHDwpBdZaWRdSF1Z EIuO+ystVFvreM3vbePw/lrYlNsdHQ==
X-Received	by 10.202.86.150 with SMTP id k144mr20929568oib.213.1499071309272; Mon, 03 Jul 2017 01:41:49 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>, Radim Krcmar <rkrcmar@redhat.com>, Wanpeng Li <wanpeng.li@hotmail.com>
X-Original-Date	Mon, 3 Jul 2017 16:41:48 +0800
X-Original-Message-ID	<CANRm+CxmyhcxPZRLOt9aTf=mT6wCiq9sJ16Ani0P4bizzEMscw@mail.gmail.com>
X-Original-References	<1498755501-39602-1-git-send-email-pbonzini@redhat.com> <1498755501-39602-4-git-send-email-pbonzini@redhat.com> <CANRm+CyD+CH=H1LFixyaqTa5j9GXMtDggseDtq+=WJ+QftvqBQ@mail.gmail.com> <CANRm+CyaunKda=pYKn5ZV_Mo4RzwTePWJ-Y0yJLptTMy0Mn+1Q@mail.gmail.com> <20be1e98-deec-ea00-32e1-251781a35f83@redhat.com> <CANRm+CwCreBC_EErbTa98dvtNzj5tzHDm1=zNozAGkVLoEXSUQ@mail.gmail.com> <c0cda5bf-eed1-9898-925d-ad99407cba09@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1679770

Show key headers only | View raw

2017-07-03 16:16 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 03/07/2017 10:08, Wanpeng Li wrote:
>>> Yeah, I'm not entirely satisfied with it but it's working: start_sw
>>> timer will see ktimer->pending and do nothing.
>>>
>>> But thinking more about it, maybe the "if (r)" can be omitted
>>> completely?  We need to benchmark it but it can be done.
>> "if (r)" makes codes more understandable, in addition, calling expired
>> the pending timer here looks weird though ktimer->pending.
>
> We can remove the call to apic_timer_expired too (sorry if I was too
> terse). :)  start_sw_period and start_sw_tscdeadline would take care of it.

IRQ disable and ktime_get() in start_sw_tscdeadline() are more
expensive. So maybe current status is a better choice. :)

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 19:00 +0200
  Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-07-02 03:40 +0200
    Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-07-02 04:00 +0200
      Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-07-03 09:40 +0200
        Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-07-03 10:10 +0200
          Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-07-03 10:20 +0200
            Re: [PATCH 3/3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-07-03 10:50 +0200

csiph-web