Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679661

Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver

Show all headers | View raw

Hi Andy and Wolfram,

On 一,  6月 26, 2017 at 06:28:14下午 +0800, Baolin Wang wrote:
> This patch adds the I2C controller driver for Spreadtrum SC9860 platform.
> 
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
> Changes since v2:
>  - Remove some redundant comments and parens.
>  - Define macros instead of magic number.
>  - Add some comments to explain clock formula.
>  - Change of_clk_get_by_name() to devm_clk_get().
>  - Deal with other frequency.
>  - Change register definiton to low case.
>  - Change is_last_msg to boolean.
>  - Other optimization.
> 
> Changes sice v1:
>  - Power on I2C device in probe().
>  - Remove redundant macros and usb __maybe_unused.
>  - Remove redundant 'of_match_ptr'.
>  - Modify return values and check the return value for 'clk_prepare_enable'.
> ---

Do you have any more comments about this patch? Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver Baolin Wang <baolin.wang@spreadtrum.com> - 2017-06-26 12:40 +0200
  Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver Baolin Wang <baolin.wang@spreadtrum.com> - 2017-07-03 08:30 +0200
  Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver Chunyan Zhang <zhang.lyra@gmail.com> - 2017-07-03 11:40 +0200
    Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver Baolin Wang <baolin.wang@spreadtrum.com> - 2017-07-06 10:40 +0200

csiph-web