Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1679669

Re: [PATCH] staging: sm750fb: refactor method and fix potential type inconsistence

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: sm750fb: refactor method and fix potential type inconsistence
Date 2017-07-03 08:30 +0200
Message-ID <tZ31U-5Fr-23@gated-at.bofh.it> (permalink)
References <tYO2S-3b9-45@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Jul 02, 2017 at 10:27:40PM +0800, Lynn Lei wrote:
> make reg variable typed `u32' not `unsigned int'
> this can fix potential type inconsistence in some platforms

It can?  What platform?

> 
> refactor swPanelPowerSequence() make the code less redundant
> 
> a early check for disp to skip unnecessary delay

Only do one thing per patch please.

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] staging: sm750fb: refactor method and fix potential type  inconsistence Lynn Lei <lynnl.wit@gmail.com> - 2017-07-02 16:30 +0200
  Re: [PATCH] staging: sm750fb: refactor method and fix potential type  inconsistence Greg KH <gregkh@linuxfoundation.org> - 2017-07-03 08:30 +0200

csiph-web