[PATCH] zram: constify attribute_group structures.

From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] zram: constify attribute_group structures.
Date	2017-07-03 08:20 +0200
Message-ID	<tZ2Sf-5BT-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   8293	    841	      4	   9138	   23b2	drivers/block/zram/zram_drv.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   8357	    777	      4	   9138	   23b2	drivers/block/zram/zram_drv.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/block/zram/zram_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index debee95..5da5c04 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1122,7 +1122,7 @@ static int zram_open(struct block_device *bdev, fmode_t mode)
 	NULL,
 };
 
-static struct attribute_group zram_disk_attr_group = {
+static const struct attribute_group zram_disk_attr_group = {
 	.attrs = zram_disk_attrs,
 };
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] zram: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-03 08:20 +0200
  Re: [PATCH] zram: constify attribute_group structures. Minchan Kim <minchan@kernel.org> - 2017-07-03 08:30 +0200
    Re: [PATCH] zram: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-03 09:20 +0200
  Re: [PATCH] zram: constify attribute_group structures. Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-07-03 11:10 +0200
    Re: [PATCH] zram: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-03 12:40 +0200
      Re: [PATCH] zram: constify attribute_group structures. Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-07-03 14:10 +0200

csiph-web