[PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

From	Janusz Lisiecki <janusz.lisiecki@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c
Date	2017-07-03 06:50 +0200
Message-ID	<tZ1t7-4u1-3@gated-at.bofh.it> (permalink)
References	<tYQR3-58Q-11@gated-at.bofh.it> <tZ1t7-4u1-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This patch fixes the following Sparse warnings in ks_wlan_net.c:
drivers/staging/ks7010/ks_wlan_net.c:1359:24: warning: cast to restricted __le16
link_ap_info_t structure field 'capability' has native order and is used everywhere
in the code in such way (i.e get_ap_information, get_current_ap). Both sides of
assignment are u16 (native order) so 'le16_to_cpu' is not needed and wrong.

Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
 drivers/staging/ks7010/ks_wlan_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 0c778aa..9a7fbe2 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -1356,7 +1356,7 @@ static inline char *ks_wlan_translate_scan(struct net_device *dev,
 
 	/* Add mode */
 	iwe.cmd = SIOCGIWMODE;
-	capabilities = le16_to_cpu(ap->capability);
+	capabilities = ap->capability;
 	if (capabilities & (BSS_CAP_ESS | BSS_CAP_IBSS)) {
 		if (capabilities & BSS_CAP_ESS)
 			iwe.u.mode = IW_MODE_INFRA;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/1] Fix cast to restricted __le16 in ks7010 driver Janusz Lisiecki <janusz.lisiecki@gmail.com> - 2017-07-02 19:30 +0200
  [PATCH 0/1] Fix cast to restricted __le16 in ks7010 driver Janusz Lisiecki <janusz.lisiecki@gmail.com> - 2017-07-03 06:50 +0200
    [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c Janusz Lisiecki <janusz.lisiecki@gmail.com> - 2017-07-03 06:50 +0200

csiph-web