Re: [PATCH 5/6] staging: iio: tsl2x7x: refactor {read,write}_event_value to allow handling multiple iio_event_infos

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] staging: iio: tsl2x7x: refactor {read,write}_event_value to allow handling multiple iio_event_infos
Date	2017-07-01 14:00 +0200
Message-ID	<tYpea-2Js-19@gated-at.bofh.it> (permalink)
References	<tXLgK-1X8-17@gated-at.bofh.it> <tXLgK-1X8-23@gated-at.bofh.it> <tYncl-1jW-15@gated-at.bofh.it> <tYnYK-1T5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 1 Jul 2017 06:37:07 -0400
Brian Masney <masneyb@onstation.org> wrote:

> On Sat, Jul 01, 2017 at 10:40:20AM +0100, Jonathan Cameron wrote:
> > On Thu, 29 Jun 2017 13:03:51 -0400
> > Brian Masney <masneyb@onstation.org> wrote:
> >   
> > > tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assumes
> > > that IIO_EV_INFO_VALUE is the only iio_event_info that will be
> > > passed in.  This patch refactors these two functions so that
> > > additional iio_event_infos can be passed in. The functions are
> > > renamed from tsl2x7x_{read,write}_thresh() to
> > > tsl2x7x_{read,write}_event_value(). This patch also adds the
> > > missing return value check to tsl2x7x_invoke_change() since this
> > > was previously missing.
> > >   
> > Hmm.. Why make this change?  Are there additional uses of this
> > function on the way?
> > 
> > If not I wouldn't necessarily worry about the naming or the
> > assumptions as the assumptions are enforced by the driver
> > anyway.  Nothing wrong with a bit of paranoid defence against
> > future  bugs, but it's not strictly necessary.  
> 
> I should have mentioned in the changelog that this change sets the
> driver up for migrating the in_intensity0_thresh_period
> and in_proximity0_thresh_period sysfs attributes to be created by
> iio_event_spec. This is one of the patches that I held back until
> I am able to properly test it.
Cool.  That's a good reason ;)
> 
> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/6] staging: iio: tsl2x7x: refactor {read,write}_event_value to allow handling multiple iio_event_infos Brian Masney <masneyb@onstation.org> - 2017-06-29 19:20 +0200
  Re: [PATCH 5/6] staging: iio: tsl2x7x: refactor  {read,write}_event_value to allow handling multiple iio_event_infos Jonathan Cameron <jic23@kernel.org> - 2017-07-01 11:50 +0200
    Re: [PATCH 5/6] staging: iio: tsl2x7x: refactor  {read,write}_event_value to allow handling multiple iio_event_infos Brian Masney <masneyb@onstation.org> - 2017-07-01 12:40 +0200
      Re: [PATCH 5/6] staging: iio: tsl2x7x: refactor  {read,write}_event_value to allow handling multiple iio_event_infos Jonathan Cameron <jic23@kernel.org> - 2017-07-01 14:00 +0200

csiph-web