Re: [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static
Date	2017-07-01 12:20 +0200
Message-ID	<tYnFo-1Km-1@gated-at.bofh.it> (permalink)
References	<tXkTg-7cj-15@gated-at.bofh.it> <tXmil-7Xs-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 28 Jun 2017 16:35:04 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:

> On 06/28/2017 03:06 PM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The array stm32h7_adc_ckmodes_spec does not need to be in global scope, so
> > make it static.
> > 
> > Cleans up sparse warning:
> > "symbol 'stm32h7_adc_ckmodes_spec' was not declared. Should it be static?"
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/iio/adc/stm32-adc-core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> > index e09233b03c05..9d083c2338f9 100644
> > --- a/drivers/iio/adc/stm32-adc-core.c
> > +++ b/drivers/iio/adc/stm32-adc-core.c
> > @@ -172,7 +172,7 @@ struct stm32h7_adc_ck_spec {
> >  	int div;
> >  };
> >  
> > -const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> > +static const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> >  	/* 00: CK_ADC[1..3]: Asynchronous clock modes */
> >  	{ 0, 0, 1 },
> >  	{ 0, 1, 2 },
> >   
> Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static Colin King <colin.king@canonical.com> - 2017-06-28 15:10 +0200
  Re: [PATCH][iio-next] iio: adc: stm32: make array  stm32h7_adc_ckmodes_spec static Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-06-28 16:40 +0200
    Re: [PATCH][iio-next] iio: adc: stm32: make array  stm32h7_adc_ckmodes_spec static Jonathan Cameron <jic23@kernel.org> - 2017-07-01 12:20 +0200

csiph-web