Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679262

Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

Show all headers | View raw

On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru
> calling mechanism to specify a different mask from the cmd_mask.
>
> Populate bus_dsm_mask and use it to filter dsm calls that user can
> make through the pass thru interface.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
>  drivers/acpi/nfit/core.c  | 8 ++++++++
>  include/linux/libnvdimm.h | 1 +
>  2 files changed, 9 insertions(+)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index b46fca2..5e4c137 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -253,6 +253,8 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
>                 cmd_name = nvdimm_bus_cmd_name(cmd);
>                 cmd_mask = nd_desc->cmd_mask;
>                 dsm_mask = cmd_mask;
> +               if (cmd == ND_CMD_CALL)
> +                       dsm_mask = nd_desc->bus_dsm_mask;
>                 desc = nd_cmd_bus_desc(cmd);
>                 uuid = to_nfit_uuid(NFIT_DEV_BUS);
>                 handle = adev->handle;
> @@ -1613,6 +1615,7 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
>         struct nvdimm_bus_descriptor *nd_desc = &acpi_desc->nd_desc;
>         const u8 *uuid = to_nfit_uuid(NFIT_DEV_BUS);
>         struct acpi_device *adev;
> +       unsigned long dsm_mask;
>         int i;
>
>         nd_desc->cmd_mask = acpi_desc->bus_cmd_force_en;
> @@ -1624,6 +1627,11 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
>                 if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i))
>                         set_bit(i, &nd_desc->cmd_mask);
>         set_bit(ND_CMD_CALL, &nd_desc->cmd_mask);
> +
> +       dsm_mask = 0x3bf;

I went ahead and fixed this up to use dsm_mask defined like this:

+       dsm_mask =
+               (1 << ND_CMD_ARS_CAP) |
+               (1 << ND_CMD_ARS_START) |
+               (1 << ND_CMD_ARS_STATUS) |
+               (1 << ND_CMD_CLEAR_ERROR) |
+               (1 << NFIT_CMD_TRANSLATE_SPA) |
+               (1 << NFIT_CMD_ARS_INJECT_SET) |
+               (1 << NFIT_CMD_ARS_INJECT_CLEAR) |
+               (1 << NFIT_CMD_ARS_INJECT_GET);

This drops function number 0 which userspace has no need to call.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] Enable DSM pass thru for root functions Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-06-30 18:20 +0200
  [PATCH v4 5/6] libnvdimm: New ACPI 6.2 DSM functions Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-06-30 18:20 +0200
  [PATCH v4 6/6] nfit allow override of root dsm mask Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-06-30 18:20 +0200
    Re: [PATCH v4 6/6] nfit allow override of root dsm mask Dan Williams <dan.j.williams@intel.com> - 2017-07-01 06:00 +0200
  [PATCH v4 4/6] acpi, nfit: Show bus_dsm_mask in sysfs Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-06-30 18:20 +0200
  [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-06-30 18:20 +0200
    Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for  pass thru. Dan Williams <dan.j.williams@intel.com> - 2017-07-01 06:00 +0200
      Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for  pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-07-01 22:00 +0200
        Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for  pass thru. Dan Williams <dan.j.williams@intel.com> - 2017-07-01 22:10 +0200
          Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for  pass thru. Dan Williams <dan.j.williams@intel.com> - 2017-07-01 22:20 +0200
            Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for  pass thru. Jerry Hoemann <jerry.hoemann@hpe.com> - 2017-07-01 22:40 +0200
              Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for  pass thru. Dan Williams <dan.j.williams@intel.com> - 2017-07-01 22:50 +0200

csiph-web