Re: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from apic_bsp_setup()

From	Dou Liyang <douly.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from apic_bsp_setup()
Date	2017-07-03 04:10 +0200
Message-ID	<tYYYh-2Op-1@gated-at.bofh.it> (permalink)
References	<tXVpM-np-9@gated-at.bofh.it> <tXVpN-np-33@gated-at.bofh.it> <tYRk5-5lI-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Thomas

At 07/03/2017 01:54 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>>  /*
>> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>> index 93f0cda..d6721f0 100644
>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -1347,8 +1347,11 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
>>  	}
>>
>>  	default_setup_apic_routing();
>> -	cpu0_logical_apicid = apic_bsp_setup(false);
>> -
>> +	apic_bsp_setup(false);
>> +	if (x2apic_mode)
>> +		cpu0_logical_apicid = apic_read(APIC_LDR);
>> +	else
>> +		cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR));
>
> Can you please move that into a seperate helper function?


Yes, it will be a separate helper function in the next version.

Thanks,

	dou.

>
>>  	/* Setup local timer */
>>  	x86_init.timers.setup_percpu_clockev();
>>
>> --
>> 2.5.5
>>
>>
>>
>>
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 04/12] x86/apic: Move logical APIC ID away from apic_bsp_setup() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-06-30 06:10 +0200
  Re: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from  apic_bsp_setup() Thomas Gleixner <tglx@linutronix.de> - 2017-07-02 20:00 +0200
    Re: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from  apic_bsp_setup() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-07-03 04:10 +0200

csiph-web