Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679603

Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt delivery modes setup

From Dou Liyang <douly.fnst@cn.fujitsu.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt delivery modes setup
Date 2017-07-03 04:00 +0200
Message-ID <tYYOC-2vJ-7@gated-at.bofh.it> (permalink)
References <tXVpM-np-9@gated-at.bofh.it> <tXVpN-np-29@gated-at.bofh.it> <tYRap-5gB-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Thomas,

At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>> +/* Init the interrupt delivery mode for the BSP */
>> +void __init apic_intr_mode_init(void)
>> +{
>> +	switch (apic_intr_mode_select()) {
>> +	case APIC_PIC:
>> +		apic_printk(APIC_VERBOSE, KERN_INFO
>> +			"Keep in PIC mode(8259)\n");
>
> Please do not proliferate that APIC_VERBOSE, KERN_INFO mess. Clean up the
> apic_printk() macro first. Either change printk() to pr_info() or make the
> printk level dependent on the APIC verbosity.

Oops, I understood, How about the following:

pr_info("APIC: keep in PIC mode(8259)\n");


Thanks,

	dou.

>
> Thanks,
>
> 	tglx
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt delivery modes setup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-06-30 06:10 +0200
  Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt  delivery modes setup Thomas Gleixner <tglx@linutronix.de> - 2017-07-02 19:50 +0200
    Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt  delivery modes setup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-07-03 04:00 +0200
      Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt  delivery modes setup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-07-03 08:50 +0200
      Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt  delivery modes setup Thomas Gleixner <tglx@linutronix.de> - 2017-07-03 08:50 +0200

csiph-web