Re: [PATCH] PCI: rcar-gen2: make of_device_ids const

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: rcar-gen2: make of_device_ids const
Date	2017-07-02 23:50 +0200
Message-ID	<tYUUG-857-15@gated-at.bofh.it> (permalink)
References	<tVtej-oa-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 23, 2017 at 02:59:52PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied with acks from Simon & Geert to pci/host-rcar for v4.13, thanks!

> ---
>  drivers/pci/host/pci-rcar-gen2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index 8534859..6f87968 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -429,7 +429,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct of_device_id rcar_pci_of_match[] = {
> +static const struct of_device_id rcar_pci_of_match[] = {
>  	{ .compatible = "renesas,pci-r8a7790", },
>  	{ .compatible = "renesas,pci-r8a7791", },
>  	{ .compatible = "renesas,pci-r8a7794", },
> -- 
> 1.9.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: rcar-gen2: make of_device_ids const Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-23 11:40 +0200
  Re: [PATCH] PCI: rcar-gen2: make of_device_ids const Simon Horman <horms@verge.net.au> - 2017-06-23 11:50 +0200
  Re: [PATCH] PCI: rcar-gen2: make of_device_ids const Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-26 10:20 +0200
  Re: [PATCH] PCI: rcar-gen2: make of_device_ids const Bjorn Helgaas <helgaas@kernel.org> - 2017-07-02 23:50 +0200

csiph-web