Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679565

Re: [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus

Show all headers | View raw

On 30/06/17 20:40, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 3:54 AM, Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
>> Rather than returning -ENODEV if i2c_pca_add_numbered_bus() fails,
>> propagate the error to aid debugging.
>>
> 
> + Suggested-by ?
> 
> You or Wolfram can use below if you agree on it (I'm fine either way):
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 

I'll include it (and the Reviewed-by) in v2 if there is one.

>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> 
>> ---
>>   drivers/i2c/busses/i2c-pca-platform.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
>> index daccef6865e8..853a2abedb05 100644
>> --- a/drivers/i2c/busses/i2c-pca-platform.c
>> +++ b/drivers/i2c/busses/i2c-pca-platform.c
>> @@ -232,9 +232,9 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
>>                          return ret;
>>          }
>>
>> -       if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>> -               return -ENODEV;
>> -       }
>> +       ret = i2c_pca_add_numbered_bus(&i2c->adap);
>> +       if (ret)
>> +               return ret;
>>
>>          platform_set_drvdata(pdev, i2c);
>>
>> --
>> 2.13.0
>>
> 
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-30 03:00 +0200
  Re: [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-30 10:50 +0200
    Re: [PATCH 3/6] i2c: pca-platform: propagate error from  i2c_pca_add_numbered_bus Wolfram Sang <wsa@the-dreams.de> - 2017-06-30 11:10 +0200
    Re: [PATCH 3/6] i2c: pca-platform: propagate error from  i2c_pca_add_numbered_bus Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-07-02 23:40 +0200
  Re: [PATCH 3/6] i2c: pca-platform: propagate error from  i2c_pca_add_numbered_bus Wolfram Sang <wsa@the-dreams.de> - 2017-07-04 16:10 +0200

csiph-web