Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679462
| From | Christian König <deathsimple@vodafone.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm: amd: amdgpu: constify ttm_place structures. |
| Date | 2017-07-02 14:50 +0200 |
| Message-ID | <tYMu5-1Un-1@gated-at.bofh.it> (permalink) |
| References | <tYJcR-7V2-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Am 02.07.2017 um 11:13 schrieb Arvind Yadav:
> ttm_place are not supposed to change at runtime. All functions
> working with ttm_place provided by <drm/ttm/ttm_placement.h> work
> with const ttm_place. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 5db0230..a2c8380 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -186,7 +186,7 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
> {
> struct amdgpu_device *adev = amdgpu_ttm_adev(bo->bdev);
> struct amdgpu_bo *abo;
> - static struct ttm_place placements = {
> + static const struct ttm_place placements = {
> .fpfn = 0,
> .lpfn = 0,
> .flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm: amd: amdgpu: constify ttm_place structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-02 11:20 +0200 Re: [PATCH] drm: amd: amdgpu: constify ttm_place structures. Christian König <deathsimple@vodafone.de> - 2017-07-02 14:50 +0200 Re: [PATCH] drm: amd: amdgpu: constify ttm_place structures. Christian König <deathsimple@vodafone.de> - 2017-07-03 09:20 +0200
csiph-web