Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

From	Hans de Goede <hdegoede@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation
Date	2017-06-30 19:50 +0200
Message-ID	<tY8dk-8qS-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <tXICf-eR-31@gated-at.bofh.it> <tY6uS-7l1-25@gated-at.bofh.it> <tY77A-7Pi-23@gated-at.bofh.it> <tY83D-8nx-9@gated-at.bofh.it> <tY8dj-8qS-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 30-06-17 19:40, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 8:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> On 30-06-17 18:37, Andy Shevchenko wrote:
>>> On Fri, Jun 30, 2017 at 6:57 PM, Benjamin Tissoires
> 
>> ACPI i2c drivers still need an empty i2c_device_id table I've
>> fixing this on my TODO but it has been buried in other stuff.
>>
>> Benjamin if (not saying you should, but if) you want to take a look at
>> this, fixing the need for the empty table for ACPI devices should be
>> easy. The problem is these lines in drivers/i2c/i2c-core.c:
>> i2c_device_probe():
>>
>>          /*
>>           * An I2C ID table is not mandatory, if and only if, a suitable
>> Device
>>           * Tree match table entry is supplied for the probing device.
>>           */
>>          if (!driver->id_table &&
>>              !i2c_of_match_device(dev->driver->of_match_table, client))
>>                  return -ENODEV;
>>
>> Which needs to be extended to also check for an ACPI match AFAIK
>> you can NOT just replace this with i2c_device_match because that would
>> break manually binding a driver through sysfs.
> 
> I have a stashed change for that, just have no time to look closer.

Care to share that? Between me and Benjamin one of us can hopefully
find the time to test / finish it (should be trivial really).

Regards,

Hans

Thread

[PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-29 14:20 +0200
  Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-29 16:30 +0200
    Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation "Rafael J. Wysocki" <rafael@kernel.org> - 2017-06-29 22:30 +0200
      Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-30 17:30 +0200
        Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Hans de Goede <hdegoede@redhat.com> - 2017-06-30 17:50 +0200
    Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Hans de Goede <hdegoede@redhat.com> - 2017-06-30 15:00 +0200
      Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-30 17:30 +0200
        Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Hans de Goede <hdegoede@redhat.com> - 2017-06-30 17:50 +0200
    Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-30 18:00 +0200
      Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-30 18:40 +0200
        Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Hans de Goede <hdegoede@redhat.com> - 2017-06-30 19:40 +0200
          Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-30 19:50 +0200
            Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Hans de Goede <hdegoede@redhat.com> - 2017-06-30 19:50 +0200
              Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-30 20:00 +0200
                Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-30 20:00 +0200
  Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation Sebastian Reichel <sre@kernel.org> - 2017-07-01 02:50 +0200
    Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng  implementation Julia Lawall <julia.lawall@lip6.fr> - 2017-07-01 22:00 +0200

csiph-web