Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1678991
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE |
| Date | 2017-06-30 18:50 +0200 |
| Message-ID | <tY7hg-7Sv-17@gated-at.bofh.it> (permalink) |
| References | <tY3x0-5xi-9@gated-at.bofh.it> <tY3x0-5xi-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: "Eric W. Biederman" <ebiederm@xmission.com> Date: Fri, 30 Jun 2017 07:39:01 -0500 > diff --git a/arch/sparc/include/uapi/asm/siginfo.h b/arch/sparc/include/uapi/asm/siginfo.h > index 2d9b79ccaa50..6bc5c677e92f 100644 > --- a/arch/sparc/include/uapi/asm/siginfo.h > +++ b/arch/sparc/include/uapi/asm/siginfo.h > @@ -17,6 +17,11 @@ > #define SI_NOINFO 32767 /* no information in siginfo_t */ > > /* > + * SIGFPE si_codes > + */ > +#define FPE_FIXME (__SI_FAULT|0) /* Broken dup of SI_USER */ > + > +/* > * SIGEMT si_codes > */ > #define EMT_TAGOVF (__SI_FAULT|1) /* tag overflow */ It's one thing to say FIXME in a comment in a kernel local header or C file. It's quite another to put this into the name of a macro which has visibility in the global user compilation namespace. I don't think you should really do that.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE "Eric W. Biederman" <ebiederm@xmission.com> - 2017-06-30 14:50 +0200
Re: [PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE David Miller <davem@davemloft.net> - 2017-06-30 18:50 +0200
Re: [PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE ebiederm@xmission.com (Eric W. Biederman) - 2017-06-30 20:30 +0200
csiph-web