Re: [PATCH] pinctrl: rza1: fix error handling

From	jmondi <jacopo@jmondi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: rza1: fix error handling
Date	2017-06-30 18:50 +0200
Message-ID	<tY7hf-7Sv-5@gated-at.bofh.it> (permalink)
References	<tY6Of-7ID-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

On Fri, Jun 30, 2017 at 06:09:53PM +0200, Arnd Bergmann wrote:
> A compiler warning points out a typo:
>

Geert already sent a fix for this
https://patchwork.kernel.org/patch/9818555/

It should have been applied already

Thanks
   j

> drivers/pinctrl/pinctrl-rza1.c: In function 'rza1_pinctrl_probe':
> drivers/pinctrl/pinctrl-rza1.c:1260:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This changes the condition to the usual check for failure of the previous
> function call.
>
> Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/pinctrl/pinctrl-rza1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
> index 614a043f3038..1d57d4480a02 100644
> --- a/drivers/pinctrl/pinctrl-rza1.c
> +++ b/drivers/pinctrl/pinctrl-rza1.c
> @@ -1257,7 +1257,7 @@ static int rza1_pinctrl_probe(struct platform_device *pdev)
>  	rza1_pctl->dev = &pdev->dev;
>
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (ret)
> +	if (!res)
>  		return -ENODEV;
>
>  	rza1_pctl->base = devm_ioremap_resource(&pdev->dev, res);
> --
> 2.9.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: rza1: fix error handling Arnd Bergmann <arnd@arndb.de> - 2017-06-30 18:20 +0200
  Re: [PATCH] pinctrl: rza1: fix error handling jmondi <jacopo@jmondi.org> - 2017-06-30 18:50 +0200

csiph-web