Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678949

[PATCH 02/10] lightnvm: pblk: fix double-free on pblk init

Show all headers | View raw

Prevent pblk->lines being double freed in case of an error during pblk
initialization.

Fixes: dd2a43437337: "lightnvm: pblk: sched. metadata on write thread"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
---
 drivers/lightnvm/pblk-init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 8bdaf7e0e00b..b3fc310aa51c 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -812,8 +812,6 @@ static int pblk_lines_init(struct pblk *pblk)
 fail_free_lines:
 	while (--i >= 0)
 		pblk_free_line_bitmaps(&pblk->lines[i]);
-
-	kfree(pblk->lines);
 fail_free_bb_aux:
 	kfree(l_mg->bb_aux);
 fail_free_bb_template:
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] lightnvm: pblk fixes for 4.13 "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 04/10] lightnvm: pblk: schedule if data is not ready "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 07/10] lightnvm: pblk: remove target using async. I/Os "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 06/10] lightnvm: pblk: use vmalloc for GC data buffer "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 09/10] lightnvm: pblk: verify that cache read is still valid "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 02/10] lightnvm: pblk: fix double-free on pblk init "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 03/10] lightnvm: pblk: remove unused return variable "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200
  [PATCH 01/10] lightnvm: pblk: fix bad le64 assignations "Javier González" <jg@lightnvm.io> - 2017-06-30 18:10 +0200

csiph-web