[PATCH 08/10] lightnvm: pblk: add initialization check

From	"Javier González" <jg@lightnvm.io>
Newsgroups	linux.kernel
Subject	[PATCH 08/10] lightnvm: pblk: add initialization check
Date	2017-06-30 18:00 +0200
Message-ID	<tY6uS-7l1-15@gated-at.bofh.it> (permalink)
References	<tY6uS-7l1-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Add a sanity check to the pblk initialization sequence in order to
ensure that enough LUNs have been allocated to store the line metadata.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
---
 drivers/lightnvm/pblk-init.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 025d8fe52154..1b0f61233c21 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -716,6 +716,12 @@ static int pblk_lines_init(struct pblk *pblk)
 	lm->emeta_bb = geo->nr_luns - i;
 	lm->min_blk_line = 1 + DIV_ROUND_UP(lm->smeta_sec + lm->emeta_sec[0],
 							geo->sec_per_blk);
+	if (lm->min_blk_line > lm->blk_per_line) {
+		pr_err("pblk: config. not supported. Min. LUN in line:%d\n",
+							lm->blk_per_line);
+		ret = -EINVAL;
+		goto fail;
+	}
 
 	ret = pblk_lines_alloc_metadata(pblk);
 	if (ret)
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 08/10] lightnvm: pblk: add initialization check "Javier González" <jg@lightnvm.io> - 2017-06-30 18:00 +0200

csiph-web