Re: [PATCH] fs: GFS2: constify attribute_group structures.

From	Bob Peterson <rpeterso@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fs: GFS2: constify attribute_group structures.
Date	2017-06-30 15:50 +0200
Message-ID	<tY4t3-682-3@gated-at.bofh.it> (permalink)
References	<tXWFb-1e4-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

----- Original Message -----
| attribute_groups are not supposed to change at runtime. All functions
| working with attribute_groups provided by <linux/sysfs.h> work with const
| attribute_group. So mark the non-const structs as const.
| 
| File size before:
|    text	   data	    bss	    dec	    hex	filename
|    5259	   1344	      8	   6611	   19d3	fs/gfs2/sys.o
| 
| File size After adding 'const':
|    text	   data	    bss	    dec	    hex	filename
|    5371	   1216	      8	   6595	   19c3	fs/gfs2/sys.o
| 
| Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Hi,

Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:

1fc2e87 GFS2: constify attribute_group structures.

Regards,

Bob Peterson
Red Hat File Systems

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fs: GFS2: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-30 07:30 +0200
  Re: [PATCH] fs: GFS2: constify attribute_group structures. Bob Peterson <rpeterso@redhat.com> - 2017-06-30 15:50 +0200

csiph-web