Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1678722
| From | Jerome Marchand <jmarchan@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling |
| Date | 2017-06-30 13:50 +0200 |
| Message-ID | <tY2AV-4WU-1@gated-at.bofh.it> (permalink) |
| References | <tXgmC-4lB-9@gated-at.bofh.it> <tXSUV-74w-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On 06/30/2017 03:24 AM, Minchan Kim wrote: >> @@ -137,6 +142,8 @@ >> * (reason above) >> */ >> #define ZS_SIZE_CLASS_DELTA (PAGE_SIZE >> CLASS_BITS) >> +#define ZS_SIZE_CLASSES DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE, \ >> + ZS_SIZE_CLASS_DELTA) > > #define ZS_SIZE_CLASSES (DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE, \ > ZS_SIZE_CLASS_DELTA) + 1) > > > I think it should add +1 to cover ZS_MIN_ALLOC_SIZE. Yes, obviously. Sorry about that. > Otherwise, looks good to me. > > Thanks. >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling "Jerome Marchand" <jmarchan@redhat.com> - 2017-06-28 10:20 +0200
Re: [PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling Minchan Kim <minchan@kernel.org> - 2017-06-30 03:30 +0200
Re: [PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling Jerome Marchand <jmarchan@redhat.com> - 2017-06-30 13:50 +0200
[PATCH v2] mm/zsmalloc: simplify zs_max_alloc_size handling "Jerome Marchand" <jmarchan@redhat.com> - 2017-06-30 14:00 +0200
Re: [PATCH v2] mm/zsmalloc: simplify zs_max_alloc_size handling Minchan Kim <minchan@kernel.org> - 2017-07-03 04:20 +0200
Re: [PATCH v2] mm/zsmalloc: simplify zs_max_alloc_size handling Minchan Kim <minchan@kernel.org> - 2017-07-03 04:20 +0200
csiph-web