Re: [PATCH v2] KVM: x86: remove ignored type attribute

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] KVM: x86: remove ignored type attribute
Date	2017-06-30 12:50 +0200
Message-ID	<tY1ER-4os-1@gated-at.bofh.it> (permalink)
References	<tVoHD-5Z8-3@gated-at.bofh.it> <tXb3A-V7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 28/06/2017 04:37, Nick Desaulniers wrote:
> The macro insn_fetch marks the 'type' argument as having a specified
> alignment.  Type attributes can only be applied to structs, unions, or
> enums, but insn_fetch is only ever invoked with integral types, so Clang
> produces 19 -Wignored-attributes warnings for this source file.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
> Changes in v2:
> * prefer memcpy
> * fix up trailing tabs
> 
>  arch/x86/kvm/emulate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 7611c034bf95..f9c0359f3fdd 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -900,7 +900,7 @@ static __always_inline int do_insn_fetch_bytes(struct x86_emulate_ctxt *ctxt,
>  	if (rc != X86EMUL_CONTINUE)					\
>  		goto done;						\
>  	ctxt->_eip += sizeof(_type);					\
> -	_x = *(_type __aligned(1) *) ctxt->fetch.ptr;			\
> +	memcpy(&_x, ctxt->fetch.ptr, sizeof(_type));		\
>  	ctxt->fetch.ptr += sizeof(_type);				\
>  	_x;								\
>  })
> 

Fixed up the tab and pushed, thanks.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: x86: remove ignored type attribute Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-23 06:50 +0200
  Re: [PATCH] KVM: x86: remove ignored type attribute Paolo Bonzini <pbonzini@redhat.com> - 2017-06-27 16:40 +0200
  [PATCH v2] KVM: x86: remove ignored type attribute Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-28 04:40 +0200
    Re: [PATCH v2] KVM: x86: remove ignored type attribute Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-06-28 04:50 +0200
    Re: [PATCH v2] KVM: x86: remove ignored type attribute Paolo Bonzini <pbonzini@redhat.com> - 2017-06-30 12:50 +0200

csiph-web