Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

From	Ryder Lee <ryder.lee@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support
Date	2017-06-29 04:10 +0200
Message-ID	<tXx46-1uW-7@gated-at.bofh.it> (permalink)
References	<tJq2t-2b3-9@gated-at.bofh.it> <tJq2t-2b3-13@gated-at.bofh.it> <tXri1-1Hi-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-06-28 at 14:53 -0500, Bjorn Helgaas wrote:
> On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote:
> > Add support for the Mediatek PCIe Gen2 controller which can
> > be found on MT7623 series SoCs.
> > 
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> >  drivers/pci/host/Kconfig         |  11 +
> >  drivers/pci/host/Makefile        |   1 +
> >  drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 565 insertions(+)
> >  create mode 100644 drivers/pci/host/pcie-mediatek.c
> >...
> 
> > +static int mtk_pcie_register_host(struct pci_host_bridge *host)
> > +{
> > +	struct mtk_pcie *pcie = pci_host_bridge_priv(host);
> > +	struct pci_bus *child;
> > +	int err;
> > +
> > +	pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
> 
> Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS
> flags?  I'd like to get rid of them because we should automatically
> assign resources if the firmware hasn't done it.
> 
> Bjorn

You're right! These flags are not needed and should be removed.
Thanks for catching that.

Ryder

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller  support Bjorn Helgaas <helgaas@kernel.org> - 2017-06-28 22:00 +0200
  Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller  support Ryder Lee <ryder.lee@mediatek.com> - 2017-06-29 04:10 +0200

csiph-web