Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677308

Re: [PATCH] module: make the modinfo name const

Show all headers | View raw

On Wed, Jun 28, 2017 at 6:32 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> This can be accomplished by makine blacklisted() also accept const.

Typo "making"

> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

But otherwise:

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  kernel/module.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 5ebe3ae2519a..7d679f3bb892 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -302,7 +302,7 @@ int unregister_module_notifier(struct notifier_block *nb)
>  EXPORT_SYMBOL(unregister_module_notifier);
>
>  struct load_info {
> -       char *name;
> +       const char *name;
>         Elf_Ehdr *hdr;
>         unsigned long len;
>         Elf_Shdr *sechdrs;
> @@ -3382,7 +3382,7 @@ int __weak module_frob_arch_sections(Elf_Ehdr *hdr,
>
>  /* module_blacklist is a comma-separated list of module names */
>  static char *module_blacklist;
> -static bool blacklisted(char *module_name)
> +static bool blacklisted(const char *module_name)
>  {
>         const char *p;
>         size_t len;
> --
> 2.10.2
>



-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] module: make the modinfo name const Kees Cook <keescook@chromium.org> - 2017-06-29 03:40 +0200

csiph-web