Re: [PATCH] rtc: brcmstb-waketimer: fix settime function

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: brcmstb-waketimer: fix settime function
Date	2017-06-29 01:20 +0200
Message-ID	<tXupz-1Aj-7@gated-at.bofh.it> (permalink)
References	<tXrrI-1Zp-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/28/2017 01:07 PM, Arnd Bergmann wrote:
> gcc warns about an unused variable in the new driver:
> 
> drivers/rtc/rtc-brcmstb-waketimer.c: In function 'brcmstb_waketmr_settime':
> drivers/rtc/rtc-brcmstb-waketimer.c:142:6: error: unused variable 'ret' [-Werror=unused-variable]
> 
> The same function also doesn't handle overflow correctly, this makes
> it return -EINVAL when passed a time that doesn't fit within the
> range of the register.

Yes, thanks for doing that.

> 
> Fixes: 9f4ad359c801 ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: brcmstb-waketimer: fix settime function Arnd Bergmann <arnd@arndb.de> - 2017-06-28 22:10 +0200
  Re: [PATCH] rtc: brcmstb-waketimer: fix settime function Florian Fainelli <f.fainelli@gmail.com> - 2017-06-29 01:20 +0200

csiph-web