Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677170

[tip:irq/core] nvme: Allocate queues for all possible CPUs

Show all headers | View raw

Commit-ID:  425a17cbfff933c4cca4eeef5caa5926d198dd85
Gitweb:     http://git.kernel.org/tip/425a17cbfff933c4cca4eeef5caa5926d198dd85
Author:     Christoph Hellwig <hch@lst.de>
AuthorDate: Mon, 26 Jun 2017 12:20:58 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Jun 2017 23:00:07 +0200

nvme: Allocate queues for all possible CPUs

Unlike most drіvers that simply pass the maximum possible vectors to
pci_alloc_irq_vectors NVMe needs to configure the device before allocting
the vectors, so it needs a manual update for the new scheme of using
all present CPUs.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <keith.busch@intel.com>
Cc: linux-block@vger.kernel.org
Cc: linux-nvme@lists.infradead.org
Link: http://lkml.kernel.org/r/20170626102058.10200-4-hch@lst.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 951042a..b3dcd7a 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1525,7 +1525,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
 	struct pci_dev *pdev = to_pci_dev(dev->dev);
 	int result, nr_io_queues, size;
 
-	nr_io_queues = num_online_cpus();
+	nr_io_queues = num_present_cpus();
 	result = nvme_set_queue_count(&dev->ctrl, &nr_io_queues);
 	if (result < 0)
 		return result;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] nvme: allocate queues for all possible CPUs Christoph Hellwig <hch@lst.de> - 2017-06-26 12:30 +0200
  [tip:irq/core] nvme: Allocate queues for all possible CPUs tip-bot for Christoph Hellwig <tipbot@zytor.com> - 2017-06-28 23:10 +0200
  Re: [PATCH 3/3] nvme: allocate queues for all possible CPUs Sagi Grimberg <sagi@grimberg.me> - 2017-07-02 19:50 +0200

csiph-web