Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1677095

Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date 2017-06-28 21:30 +0200
Message-ID <tXqP0-1wb-11@gated-at.bofh.it> (permalink)
References <tX1dU-2UD-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.

This isn't a good changelog, what are the warnings and why are we fixing
them?  The fact that checkpatch complains isn't meaningful in and of
itself - it's OK to say that checkpatch helped identify issues but it's
not perfect and we need to understand what is being changed and why.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Aravind Thokala <aravind.thk@gmail.com> - 2017-06-27 18:10 +0200
  Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Mark Brown <broonie@kernel.org> - 2017-06-28 21:30 +0200
    Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Aravind Thokala <aravind.thk@gmail.com> - 2017-06-30 19:40 +0200

csiph-web