Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676987

Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled

From Jens Axboe <axboe@kernel.dk>
Newsgroups linux.kernel
Subject Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled
Date 2017-06-28 20:00 +0200
Message-ID <tXpq4-t5-209@gated-at.bofh.it> (permalink)
References <tXppX-t5-71@gated-at.bofh.it> <tXppX-t5-69@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 06/28/2017 11:10 AM, Keith Busch wrote:
> On Wed, Jun 28, 2017 at 11:32:51AM -0500, wenxiong@linux.vnet.ibm.com wrote:
>> diff --git a/fs/block_dev.c b/fs/block_dev.c
>> index 519599d..e871444 100644
>> --- a/fs/block_dev.c
>> +++ b/fs/block_dev.c
>> @@ -264,6 +264,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
>>  
>>  	if (unlikely(bio.bi_error))
>>  		return bio.bi_error;
>> +
>> +	if (bio_integrity(&bio))
>> +		bio_integrity_free(&bio);
>> +
>>  	return ret;
>>  }
> 
> We don't want to leak the integrity payload in case of bi_error either.

Yep, see my follow up email on this.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] fs: System memory leak when running HTX with T10 DIF  enabled Keith Busch <keith.busch@intel.com> - 2017-06-28 20:00 +0200
  Re: [PATCH] fs: System memory leak when running HTX with T10 DIF  enabled Jens Axboe <axboe@kernel.dk> - 2017-06-28 20:00 +0200
  Re: [PATCH] fs: System memory leak when running HTX with T10 DIF         enabled Christoph Hellwig <hch@lst.de> - 2017-06-28 20:40 +0200
    Re: [PATCH] fs: System memory leak when running HTX with T10 DIF         enabled Christoph Hellwig <hch@lst.de> - 2017-06-28 20:40 +0200
      Re: [PATCH] fs: System memory leak when running HTX with T10 DIF         enabled Christoph Hellwig <hch@lst.de> - 2017-06-28 21:00 +0200
        Re: [PATCH] fs: System memory leak when running HTX with T10 DIF         enabled Christoph Hellwig <hch@lst.de> - 2017-06-28 23:20 +0200
        Re: [PATCH] fs: System memory leak when running HTX with T10 DIF  enabled Shaohua Li <shli@kernel.org> - 2017-06-28 23:20 +0200
          Re: [PATCH] fs: System memory leak when running HTX with T10 DIF         enabled Christoph Hellwig <hch@lst.de> - 2017-06-28 23:30 +0200

csiph-web