Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1676928

Re: rsi: add in missing RSI_FSM_STATES into array fsm_state

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: rsi: add in missing RSI_FSM_STATES into array fsm_state
Date 2017-06-28 20:00 +0200
Message-ID <tXppY-t5-77@gated-at.bofh.it> (permalink)
References <tVdCA-7lD-67@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Colin Ian King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED
> and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state
> was not updated to match. This can lead to an array overrun when
> accessing the latter two states in fsm_state. Fix this by adding in
> the missing states.
> 
> Detected by CoverityScan, CID#1398379 ("Illegal address computation")
> 
> Fixes: 9920322ccd8e ("rsi: add tx frame for common device configuration")
> Fixes: 015e367494c1 ("rsi: Register interrupt handler before firmware load")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied to wireless-drivers-next.git, thanks.

58828680af49 rsi: add in missing RSI_FSM_STATES into array fsm_state

-- 
https://patchwork.kernel.org/patch/9804857/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] rsi: add in missing RSI_FSM_STATES into array fsm_state Colin King <colin.king@canonical.com> - 2017-06-22 19:00 +0200
  Re: [PATCH] rsi: add in missing RSI_FSM_STATES into array fsm_state Kalle Valo <kvalo@codeaurora.org> - 2017-06-28 20:00 +0200
  Re: rsi: add in missing RSI_FSM_STATES into array fsm_state Kalle Valo <kvalo@codeaurora.org> - 2017-06-28 20:00 +0200

csiph-web