[PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async

From	Long Li <longli@exchange.microsoft.com>
Newsgroups	linux.kernel
Subject	[PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async
Date	2017-06-28 20:00 +0200
Message-ID	<tXppX-t5-57@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Long Li <longli@microsoft.com>

In cifs_call_async, server response may return as soon as I/O is submitted.
Do not touch it after that.

Signed-off-by: Long Li <longli@microsoft.com>
---
 fs/cifs/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index 47a125e..ba62aaf 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst,
 	spin_unlock(&GlobalMid_Lock);
 
 
+	cifs_save_when_sent(mid);
 	cifs_in_send_inc(server);
 	rc = smb_send_rqst(server, rqst, flags);
 	cifs_in_send_dec(server);
-	cifs_save_when_sent(mid);
 
 	if (rc < 0) {
 		server->sequence_number -= 2;
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async Long Li <longli@exchange.microsoft.com> - 2017-06-28 20:00 +0200

csiph-web