Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676918

Re: [PATCH v5] trace: ras: add ARM processor error information trace event

Show all headers | View raw

On Wed, Jun 28, 2017 at 05:42:42PM +0100, James Morse wrote:
> > Alternatively, you can extend arm_event to get issued with *each*
> > cper_arm_err_info but that would mean a lot of redundant information
> > being shuffled out to userspace.
> 
> I think this is what we should do,

Yes, that should be easier for userspace.

> but only keep the number of fields we export to a minimum. If we
> always use the names in the spec, and user-space always parses the
> 'format' file, we should be able to add more fields when they turn out
> to be necessary. (looks like the trace infrastructure makes inventing
> a new format easy!)

Right, except if you have userspace consumers already using them, you're
potentially breaking them. Unless you teach them all to parse the format
file first, from the very beginning. But in general, we try to be very
wary when touching tracepoints as they become an ABI of sorts.

Also, do try to shovel only the really needed info to userspace - not
everything the spec dumps but maybe just the fields that are really
necessary for doing hw error recovery.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] trace: ras: add ARM processor error information trace event Xie XiuQi <xiexiuqi@huawei.com> - 2017-06-24 05:50 +0200
  Re: [PATCH v5] trace: ras: add ARM processor error information  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-06-26 15:40 +0200
    Re: [PATCH v5] trace: ras: add ARM processor error information trace  event Xie XiuQi <xiexiuqi@huawei.com> - 2017-06-27 04:50 +0200
      Re: [PATCH v5] trace: ras: add ARM processor error information  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-06-27 16:20 +0200
  Re: [PATCH v5] trace: ras: add ARM processor error information trace  event Borislav Petkov <bp@suse.de> - 2017-06-26 16:10 +0200
    Re: [PATCH v5] trace: ras: add ARM processor error information trace  event Xie XiuQi <xiexiuqi@huawei.com> - 2017-06-27 09:00 +0200
      Re: [PATCH v5] trace: ras: add ARM processor error information trace  event Borislav Petkov <bp@suse.de> - 2017-06-27 09:30 +0200
        Re: [PATCH v5] trace: ras: add ARM processor error information trace  event "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-06-27 17:50 +0200
          Re: [PATCH v5] trace: ras: add ARM processor error information trace  event Borislav Petkov <bp@suse.de> - 2017-06-27 18:30 +0200
    Re: [PATCH v5] trace: ras: add ARM processor error information trace  event Borislav Petkov <bp@suse.de> - 2017-06-28 20:00 +0200
      Re: [PATCH v5] trace: ras: add ARM processor error information  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-06-28 20:00 +0200
    Re: [PATCH v5] trace: ras: add ARM processor error information trace  event James Morse <james.morse@arm.com> - 2017-06-28 20:00 +0200

csiph-web